feat(progress-bar): update styles to iOS 17 specs #28759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
requested review from
liamdebeasi
and removed request for
a team
mapsandapps
suggested changes
Dec 27, 2023
liamdebeasi
reviewed
Jan 2, 2024
Comment on lines
-17
to
-23
| .custom-bar-background { | ||
| --buffer-background: red; | ||
| } | ||
|
|
||
| .no-bar-background { | ||
| --buffer-background: none; | ||
| } |
There was a problem hiding this comment.
These classes were not applied anywhere in the file
liamdebeasi
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
Ionic's progress bar implementation deviates from the appearance of a progress bar on iOS 17.
What is the new behavior?
4px1) will have a consistent background appearance.Does this introduce a breaking change?
Breaking Changes
--buffer-backgroundhas been removed in favor of--background.Other information
Accomplishing rounded caps for the inner progress with Ionic's scale transformation was not viable. To maintain 60fps animations for the progress, rounded corners were applied to the container.