Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): remove uneeded border radius from items in inset list #28830

Merged
merged 1 commit into from Jan 16, 2024

Conversation

amandaejohnston
Copy link
Contributor

@amandaejohnston amandaejohnston commented Jan 15, 2024

Issue number: N/A


What is the current behavior?

In MD mode, items in an inset list currently receive their own border radius, separate from the border radius also applied to the inset list itself. The original intent was likely to ensure that the corners of the items don't spill out of the list. However, the item's border radius is no longer needed, for two reasons:

  1. MD has since added top/bottom padding to their lists (spec), which we've mirrored. This means the borders no longer line up anyway.
  2. Even if a developer removes the list's vertical padding (we set it on the host here, so it's easy to overwrite), inset lists currently have overflow: hidden set here, so the list's border radius still applies correctly even with the items' border radius removed.

What is the new behavior?

Item border radius in inset lists removed.

When testing locally, you may find it useful to increase the MD border radius value here so it's easier to see.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Jan 15, 2024
@amandaejohnston amandaejohnston marked this pull request as ready for review January 15, 2024 19:45
@amandaejohnston amandaejohnston requested a review from a team as a code owner January 15, 2024 19:45
@amandaejohnston amandaejohnston requested review from liamdebeasi and removed request for a team January 15, 2024 19:45
Copy link
Member

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would consider this a fix though since it's removing buggy behavior.

@amandaejohnston amandaejohnston changed the title refactor(list): remove uneeded border radius from items in inset list fix(list): remove uneeded border radius from items in inset list Jan 16, 2024
@amandaejohnston amandaejohnston added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit dbaaa5b Jan 16, 2024
46 checks passed
@amandaejohnston amandaejohnston deleted the FW-5532 branch January 16, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants