Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datetime): enter closes keyboard when typing time #28848

Merged
merged 5 commits into from
Jan 18, 2024
Merged

fix(datetime): enter closes keyboard when typing time #28848

merged 5 commits into from
Jan 18, 2024

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 17, 2024 •
edited
Loading

Issue number: resolves #28325

What is the current behavior?

When typing the time into the date picker pressing "Enter" does not close the on-screen keyboard.

What is the new behavior?

  • Pressing "Enter" closes the on-screen keyboard

Does this introduce a breaking change?

  • Yes
  • No

Other information

Test:

⚠️ While I have a test for this, please also test this on a physical Android device.

  1. Go to src/components/datetime/test/basic
  2. Open the time picker (in any of the date times)
  3. Tap the time to open the keyboard
  4. Press "Enter" on Android. Observe that the keyboard closes.

Dev build: 7.6.6-dev.11705528328.1ef5e17b

@liamdebeasi liamdebeasi changed the title Fw 5377 fix(datetime): enter closes keyboard when typing time Jan 17, 2024
@github-actions github-actions bot added the package: core @ionic/core package label Jan 17, 2024
@liamdebeasi liamdebeasi marked this pull request as ready for review January 17, 2024 22:04
@liamdebeasi liamdebeasi requested review from a team and averyjohnston and removed request for a team January 17, 2024 22:04
averyjohnston
averyjohnston reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my actual Android phone and works as written, just had a question about the strategy.

core/src/components/picker-internal/picker-internal.tsx Show resolved Hide resolved
@liamdebeasi liamdebeasi added this pull request to the merge queue Jan 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 18, 2024
@liamdebeasi liamdebeasi added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit c47a16d Jan 18, 2024
46 checks passed
@liamdebeasi liamdebeasi deleted the FW-5377 branch January 18, 2024 18:27
@liamdebeasi liamdebeasi mentioned this pull request Jan 18, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averyjohnston averyjohnston averyjohnston approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: datetime, go button in number pad doesn't do anything
2 participants
@liamdebeasi @averyjohnston