fix(react): route with redirect will mount page #28961
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28838
What is the current behavior?
In #28316 we resolved a longstanding misconfiguration where event listeners being added to the page were not removed. This was due to incorrect usage of
.bind
creating a new instance of the callback functions.By removing the event listener for
ionViewDidLeave
, before the component has actually unmounted in react, resulted in the registered destroy callback to not fire:ionic-framework/packages/react/src/contexts/IonLifeCycleContext.tsx
Lines 208 to 216 in 51c729e
ionic-framework/packages/react/src/routing/ViewLifeCycleManager.tsx
Lines 21 to 32 in 51c729e
This resulted in a scenario that using a
Redirect
could cause the wrong view to be unmounted (the entering view) and leave the user on an empty screen.What is the new behavior?
ionViewDidEnter
event listener is not removed while the component is unmounting. The browser will naturally remove the event listener when the element node is detached from the DOM.Does this introduce a breaking change?
Other information
Dev-build:
7.6.7-dev.11706567011.11e782a9