Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Capacitor compose 1.5 to 1.6 #29144

Closed
3 tasks done
andretortolano opened this issue Mar 12, 2024 · 4 comments
Closed
3 tasks done

bug: Capacitor compose 1.5 to 1.6 #29144

andretortolano opened this issue Mar 12, 2024 · 4 comments
Assignees
Labels

Comments

@andretortolano
Copy link

Prerequisites

Ionic Framework Version

v7.x

Current Behavior

I have a custom capacitor that under the hood uses compose for rendering views on the android front, everything was working well and fine but if I try to pump up our native library version that brings compose 1.6.x instead of the current 1.5.x, I start seeing a lot of issues, and upon further inspection it seems like its grabbing a bunch of compose*-desktop modules instead of compose*-android ones.

Expected Behavior

The expected behavior would be to simply update the library and continue using compose in its latest available version

Steps to Reproduce

  1. create project from scratch
  2. import androidx.compose.ui:ui:1.6.3 library
  3. sync project and run task androidDependencies there will be a bunch of compose*-desktop which is wrong

for testing purposes, if you fall back to 1.5.2 and run androidDependencies again everything looks correct

Code Reproduction URL

n/a

Ionic Info

Ionic:

Ionic CLI : 7.2.0 (/Users/andret/.nvm/versions/node/v16.20.2/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/react 5.9.4

Capacitor:

Capacitor CLI : 5.1.1
@capacitor/android : 5.1.1
@capacitor/core : 5.1.1
@capacitor/ios : 5.1.1

Utility:

cordova-res : not installed globally
native-run (update available: 2.0.1) : 1.7.2

System:

NodeJS : v16.20.2 (/Users/andret/.nvm/versions/node/v16.20.2/bin/node)
npm : 8.19.4
OS : macOS Unknown

Additional Information

This update is working on Flutter, I'm not sure who needs to fix this (if this is an issue with Ionic or with the androidx lib) in any case I opened an issue on their end as well.

https://issuetracker.google.com/issues/329138765

this is the library in question that we provide as a wrapper of our android and ios native implementations

@liamdebeasi
Copy link
Contributor

Thanks for the issue. I am going to close this as this is not a bug in Ionic Framework. This repo is for Ionic Framework which only deals with the user interface layer of your application and not any native dependencies. I spoke with the Capacitor team, and Capacitor does not use the compose dependency, so it does not appear to be a Capacitor issue either.

I recommend posting on the Ionic Forum for help debugging this issue. If you are able to point to something inside of Capacitor that is causing this issue, then feel free to create an issue on the Capacitor repo. Let me know if you have any questions!

@liamdebeasi liamdebeasi closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
@andretortolano
Copy link
Author

I agree this is not directly impacted because of the ionic frame work but it looks like there will be eventually a need to include kotlin gradle plugin for projects just like Flutter does so that androidx components that are built using Kotlin multi-platform (from what I understood) can pick up the proper platform and download the correct packages

https://issuetracker.google.com/issues/328687152

@liamdebeasi
Copy link
Contributor

liamdebeasi commented Mar 13, 2024

In that case I recommend filing feedback on the Capacitor repo. Ionic Framework does not handle the native runtime, so any necessary code modifications would not be made in this repo.

Copy link

ionitron-bot bot commented Apr 12, 2024

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants