New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: in IonRouterOutlet types does not follow the proper type documentation #29170
Comments
Same issue here. I am working around with a |
Same issue for me |
Thanks for the issue! This issue is being closed due to the lack of a code reproduction. As noted in the issue template, we need a runnable sample to verify this report. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. Thank you for using Ionic! |
I hit this same issue today. To reproduce, create a new project with App.jsx fails TS checks on |
Same issue here. |
Also having the same issue with a new project using ionic + react. In my case I did use the creation wizard. |
The {
...
- onPointerEnterCapture?: PointerEventHandler<T> | undefined;
- onPointerLeaveCapture?: PointerEventHandler<T> | undefined;
+ onPointerEnterCapture: unknown
+ onPointerLeaveCapture: unknown
} |
You can specify the |
Same issue here |
Hi everyone, We are tracking this in #29178. Unfortunately, Definitely Typed made a breaking change to the types that caused breakages in developer applications (it was classified as a bug fix, but it is causing some apps to no longer compile). We are working with the Stencil team to mitigate this. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Prerequisites
Ionic Framework Version
v7.x
Current Behavior
in IonRouterOutlet types does not follow the proper type documentation, onPointerEnterCapture, onPointerLeaveCapture are included in theOmit<React.HTMLAttributes.
Before releasing the version8.x it was working fine without providing the properties in IonRouterOutlet.
Expected Behavior
It should not ask for the missing properties which are Omitted.
Steps to Reproduce
install Ionic/react 7.0.0 and Ionic/react-router 7.0.0 and Use IonRouterOutlet for routing with Private routes it won't allow with the above mentioned missing property
// onPointerEnterCapture={captureEventOnEnter} onPointerLeaveCapture={undefined}
</IonRouterOutlet
Code Reproduction URL
i do not have hosted code sample project
Ionic Info
error TS2739: Type '{ children: Element[]; }' is missing the following properties from type 'Pick<IonRouterOutlet & { basePath?: string | undefined; ref?: Ref | undefined; ionPage?: boolean | undefined; } & IonicReactProps & Omit<...>, "defaultChecked" | ... 253 more ... | "ionPage">': onPointerEnterCapture, onPointerLeaveCapture
this is the error message getting deploying
Additional Information
No response
The text was updated successfully, but these errors were encountered: