Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Filled Input changing the centered vertically of label when switch font-family css #29181

Closed
3 tasks done
WillxRv opened this issue Mar 19, 2024 · 6 comments
Closed
3 tasks done
Assignees
Labels

Comments

@WillxRv
Copy link

WillxRv commented Mar 19, 2024

Prerequisites

Ionic Framework Version

v7.x

Current Behavior

When changing the css font-family of an filled input the label does not remain centered vertically

bug

Expected Behavior

When changing the font, the label remains vertically centered

Steps to Reproduce

  1. Create a filled input
  2. Change css font-family (example: "font-family: 'Nunito', 'sans-serif'")

Code Reproduction URL

https://stackblitz.com/edit/ionic7-label-test-umsdff?file=src%2Fapp%2Fapp.component.html

Ionic Info

Ionic:

Ionic CLI : 6.20.3 (C:\Users\Usuario\AppData\Roaming\npm\node_modules@ionic\cli)
Ionic Framework : not installed
@angular-devkit/build-angular : 17.3.0
@angular-devkit/schematics : 17.3.0
@angular/cli : 17.3.0
@ionic/angular-toolkit : 9.0.0

Capacitor:

Capacitor CLI : 5.7.3
@capacitor/android : not installed
@capacitor/core : 5.7.3
@capacitor/ios : not installed

Utility:

cordova-res : not installed globally
native-run : 2.0.1

System:

NodeJS : v18.18.2 (C:\Program Files\nodejs\node.exe)
npm : 9.8.1
OS : Windows 10

Additional Information

No response

@liamdebeasi
Copy link
Contributor

Thanks for the report. What browser are you testing this on? I'm not able to reproduce this on Safari or Chrome.

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Mar 19, 2024
@ionitron-bot ionitron-bot bot removed the triage label Mar 19, 2024
@WillxRv
Copy link
Author

WillxRv commented Mar 19, 2024

Thanks for response.

I'm ussing Chrome, version 122.0.6261.129, but this issue also occurs after compiling with capacitor and in Stackblitz

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Mar 19, 2024
@liamdebeasi
Copy link
Contributor

liamdebeasi commented Mar 19, 2024

I can reproduce this using other font families such as "Comic Sans MS" instead of the "Nunito" font. This looks to be the same underlying problem as #27194. The reference issue is changing the font size, but the root issue appears to be that our "center positioning" logic is not very reliable with custom scenarios. I am going to merge the two threads, but let me know if you have questions.

@liamdebeasi liamdebeasi closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2024
@WillxRv
Copy link
Author

WillxRv commented Apr 3, 2024

I can reproduce this using other font families such as "Comic Sans MS" instead of the "Nunito" font. This looks to be the same underlying problem as #27194. The reference issue is changing the font size, but the root issue appears to be that our "center positioning" logic is not very reliable with custom scenarios. I am going to merge the two threads, but let me know if you have questions.

Can you tell me if this will be or has already been fixed? Thanks

@liamdebeasi
Copy link
Contributor

The issue has not been fixed yet. You can follow #27194 for updates on this issue.

Copy link

ionitron-bot bot commented May 3, 2024

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants