Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAINING] bug: button retained in memory after removed from DOM #29417

Closed
3 tasks done
liamdebeasi opened this issue Apr 29, 2024 · 0 comments
Closed
3 tasks done

[TRAINING] bug: button retained in memory after removed from DOM #29417

liamdebeasi opened this issue Apr 29, 2024 · 0 comments
Labels

Comments

@liamdebeasi
Copy link
Contributor

liamdebeasi commented Apr 29, 2024

Important

The contents of this thread are for training purposes only and do not represent an actual memory leak in Ionic Framework. If you think you've found a bug in Ionic, please file an issue.

Prerequisites

Ionic Framework Version

v8.x

Current Behavior

The trigger button for the Modal is retained in memory even after it is removed from the DOM.

Expected Behavior

I expect the trigger button to not be retained in memory after it is removed from the DOM.

Steps to Reproduce

  1. Clone the reproduction sample.
  2. Run npm install in the core directory to install dependencies.
  3. Run npm run start to start the Stencil dev server.
  4. Navigate to http://localhost:3333/src/components/modal/test/trigger
  5. Click "Agree and Continue". The "Open Terms of Service" button will be removed from the DOM, but it will still be retained in memory.

Code Reproduction URL

https://github.com/liamdebeasi/framework-training-leak-2

Ionic Info

Ionic v8.0.1

Additional Information

No response

Note

There is a second memory leak here! This memory leak occurs on the original trigger button when the trigger property on the Modal changes to reference a different element. Can you find the source of the leak?

@ionitron-bot ionitron-bot bot added the triage label Apr 29, 2024
@liamdebeasi liamdebeasi closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
@ionic-team ionic-team locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants