Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single tap fires twice in the same location #559

Closed
heshiming opened this issue Feb 8, 2014 · 6 comments
Closed

Single tap fires twice in the same location #559

heshiming opened this issue Feb 8, 2014 · 6 comments
Assignees
Milestone

Comments

@heshiming
Copy link

I'm getting two taps on the same location for a single tap, on the nav-bar. This happens on my iOS 6 & 7 device, and emulator. It happens in Mobile Safari, as well as UIWebView contained by cordova. I've tested this on commit 7f9bfb5 .

The code to reproduce this behavior is at http://codepen.io/anon/pen/mLrnb , however, visiting this codepen page in Mobile Safari won't trigger the bug for some reason. You have to save it locally, and serve via http-server -p 8000 .

The behavior is: When you tap the icon at top right to activate the side menu, the menu will open, but the tap is fired again on the side menu, causing another navigation (to the new page in red background). It happens not 100% of the time, but likely more than 90%.

At this point, if you click the side menu icon again to deactivate it, you can see the side menu closing up, but then another tap hit the 'back' button, which triggered another navigation back to the index page.

The two taps are fired at the same coordinate of the viewport, not the same element, leading me to think this is not a problem of my code.

@alexbainbridge
Copy link

Just to add to this, I have a "close" button on a modal that when you click the close (in the modal), the tap now also fires in the position underneath the modal, on the nav bar. Sounds the same kind of issue.
This is "recent" - i.e a change introduced in the last 7 days

@adamdbradley adamdbradley added this to the 0.9.25 milestone Feb 10, 2014
@adamdbradley adamdbradley self-assigned this Feb 10, 2014
@CoenWarmer
Copy link

I can also verify this happens with an element using ng-href in the footer bar.

If you hold down the button (mouse or touch) the item fires once. If you tap it quickly, it fires twice.

@adamdbradley
Copy link
Contributor

Hopefully this is a duplicate of #573, which went into the nightly build yesterday. Would you be able to test against the nightly build to see if this issue was corrected?
http://code.ionicframework.com/#nightly

@heshiming
Copy link
Author

@adamdbradley thank you very much! I can confirm that in the latest commit 7f9bfb5 , this problem went away.

@adamdbradley adamdbradley modified the milestones: 0.9.24, 0.9.25 Feb 11, 2014
@adamdbradley
Copy link
Contributor

Awesome, thanks for double checking.

@kbaxx
Copy link

kbaxx commented Feb 26, 2016

i am getting this problem again with the following stack:

Info:
Cordova CLI: 6.0.0
Ionic Version: 1.2.4
Ionic CLI Version: 1.7.14
Ionic App Lib Version: 0.7.0
ios-deploy version: 1.8.2
ios-sim version: 5.0.2
OS: Mac OS X El Capitan
Node Version: v4.0.0
Xcode version: Xcode 7.2.1 Build version 7C1002

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants