Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware back button does not close tab's pages and modals. #6574

Closed
mnasyrov opened this issue May 19, 2016 · 2 comments
Closed

Hardware back button does not close tab's pages and modals. #6574

mnasyrov opened this issue May 19, 2016 · 2 comments
Assignees
Milestone

Comments

@mnasyrov
Copy link

Short description of the problem:

The current implementation of a hardware back button (ionic2, beta.6) does not take into account a case when an active tab has its own non-empty ViewController (an opened page, modal or alert). In this case an application is closed after pressing the back button.

What behavior are you expecting?

When a hardware button is pressed then an active item must be closed at the first (alerts, modals and etc.). Only after that an active page of a current page stack should be closed. Application should be closed if there is only a root page without any active child.

Which Ionic Version? 1.x or 2.x
2.x (2.0.0-beta.6-201605132240)

Plunker that shows an example of your issue

http://plnkr.co/edit/kLT7lDjMTN0PaUNV0Vjm?p=preview

@webprofusion-chrisc
Copy link

This would apply for Action Sheets as well (invoking the handler for the 'cancel' role).

@adamdbradley
Copy link
Contributor

This should be fixed as of this commit: 9f293e8

Thanks for filing the issue!

@adamdbradley adamdbradley self-assigned this Jun 8, 2016
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants