Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item: clean up the content projection #6849

Closed
brandyscarney opened this issue Jun 10, 2016 · 5 comments
Closed

Item: clean up the content projection #6849

brandyscarney opened this issue Jun 10, 2016 · 5 comments

Comments

@brandyscarney
Copy link
Member

brandyscarney commented Jun 10, 2016

The content projection has been pretty confusing. I've updated the API docs to try to explain it better, but it is still confusing that if an ion-label exists it will ignore any other elements but if no ion-label is passed it will place it inside of the ion-label. Discuss! 😉

Forum discussion: https://forum.ionicframework.com/t/confused-about-ion-item-usage/54116/

@brandyscarney
Copy link
Member Author

I know the point of this was so that users could write a simple item like:

<ion-item>
  my item
</ion-item>

and they wouldn't have to wrap it in an ion-label, but I think this is causing more confusion than writing more markup would.

@xr0master
Copy link
Contributor

I think if you add examples from the forum topic in the API item documentation, it will be enough. IMO

@jgw96
Copy link
Contributor

jgw96 commented Jun 13, 2016

This issue is related: #6861

@brandyscarney
Copy link
Member Author

I'm going to close this issue because the documentation has been updated for item to reflect where the content is projected. For more information on the current state of being able to nest components with content projection, see this comment: #12252 (comment)

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 2, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants