Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

The rAF function typo (?) #6

Closed
alangrus opened this issue May 30, 2014 · 3 comments
Closed

The rAF function typo (?) #6

alangrus opened this issue May 30, 2014 · 3 comments

Comments

@alangrus
Copy link

In trying to get the demo to work locally, I kept noticing the console showing issues with the window.rAF function not being found. So I snoop around and find that there IS a window._rAF function. I added the underscore in 3 places in the ionic.cards.js file starting at line 211 as below, and now it works.

screen shot 2014-05-29 at 5 42 22 pm

@paishin
Copy link

paishin commented Aug 13, 2014

it seems that some browsers support rAF, some _rAF and some requestAnimationFrame, depending on which browser and what platform you are running on you might need to switch to the version that works for you.

Unfortunately, I am not aware of a way to identify which version available on each platform dynamically.

@mlynch
Copy link
Contributor

mlynch commented Aug 13, 2014

This was recently fixed. Thanks!

See this commit: b027e39#diff-862ae897bda2dfe199b5dd113d021db5R211

@mlynch mlynch closed this as completed Aug 13, 2014
@paishin
Copy link

paishin commented Aug 14, 2014

@mlynch you are right, I was using an older version, just updated to the latest release and seems to be resolved.

I still have the problem where on the device the card does not follow the finger.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants