Make PortalsPubSub.publish non-blocking #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subscribers were published to. In practice this is unlikely to be noticeable, but if there are many subscribers it could potentially block the caller for an inordinate amount of time. chore: Add test helpers for Combine and update tests to use them. chore: Remove NSLog from objective-c tests.
Steven0351
commented
May 18, 2022
| @@ -11,7 +11,7 @@ import Capacitor | |||
|
|
|||
| /// An interface that enables marshalling data to and from a ``Portal`` over an event bus | |||
| public enum PortalsPubSub { | |||
| private static let queue = DispatchQueue(label: "io.ionic.portals.pubsub", attributes: .concurrent) | |||
| private static let queue = DispatchQueue(label: "io.ionic.portals.pubsub") | |||
There was a problem hiding this comment.
This is now a serial queue because we want to ensure messages are delivered in order
Steven0351
commented
May 18, 2022
| @@ -69,7 +69,7 @@ public enum PortalsPubSub { | |||
| /// - topic: The topic to unsubscribe from | |||
| /// - subscriptionRef: The subscriptionRef provided during subscription | |||
| public static func unsubscribe(from topic: String, subscriptionRef: Int) { | |||
| queue.async(flags: .barrier) { | |||
| queue.async { | |||
There was a problem hiding this comment.
The barrier flag is no longer needed because we're using a serial queue now.
carlpoole
approved these changes
May 18, 2022
giralte-ionic
approved these changes
May 18, 2022
| import XCTest | ||
|
|
||
| extension Publisher { | ||
| func expectOutput( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: The publish function was blocking callers who publish until all subscribers were published to. In practice this is unlikely to be noticeable, but if there are many subscribers it could potentially block the caller for an inordinate amount of time.
chore: Add test helpers for Combine and update tests to use them.
chore: Remove NSLog from objective-c tests.