fix: fix base64url conversion #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpoole
approved these changes
Oct 10, 2022
giralte-ionic
approved these changes
Oct 10, 2022
carlpoole
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing base64url conversion to base64 is unsound. The current operation as it exists uses the remainder as the padding amount, which means that padding could be potentially over applied. This has not occurred because it appears that our signature of the data has always had a remainder of 2. I assume this is the case because the size of the data we're signing itself is always the same regardless of the key, but if that changes then the current implementation will cause a crash.