This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
fix: jest.mock() is not allowed to reference any out-of-scope variables #18
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anantoghosh
force-pushed
the
fix/reference-out-of-scope
branch
from
b0d55e7
to
d16875d
Compare
|
Thank you very much for the PR! We appreciate the work you put into resolving this. I ended up creating separate PRs so each fix shows up as a separate commit, but I gave you co-author credit in af458a8 and e0d76d0. These fixes should be available in the next release of Ionic React Test Utils. I am going to close this since the other PRs resolved the issues. |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with mock variable names.
The variable names are derived from the imported file name instead of the imported variable name.
Current build imports
IonInputfrom@ionic/reactwhich gets the var name as react_1 which is out of scope of the jest mock which jest will complain about.This PR uses the IonInput from the
restvariable which is in the mock scope.The import mockUseIonPicker gets the name from the filename instead of the export variable name in the build causing it to lose the mock in front of it. This PR renames the file to include mock in it.
fixes #18