Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Wrong information about the logo-* Ionicons #583

Closed
iignatov opened this issue Apr 27, 2016 · 1 comment
Closed

docs: Wrong information about the logo-* Ionicons #583

iignatov opened this issue Apr 27, 2016 · 1 comment
Assignees

Comments

@iignatov
Copy link

The instructions for the logo-* icons (e.g. logo-javascript) on the Ionicons docs page are incorrect.

Currently the usage instructions (e.g. for logo-javascript) are:

  <!--Basic: auto-select the icon based on the platform -->
  <ion-icon name="javascript"></ion-icon>

  <!-- Advanced: explicity set the icon for each platform -->
  <ion-icon ios="logo-javascript" md="logo-javascript"></ion-icon>

but instead they should be:

  <!--Basic: auto-select the icon based on the platform -->
  <ion-icon name="logo-javascript"></ion-icon>

  <!-- Advanced: explicity set the icon for each platform -->
  <ion-icon ios="logo-javascript" md="logo-javascript"></ion-icon>

or even better (because the name is the same for all platforms):

  <ion-icon name="logo-javascript"></ion-icon>

The title should also display the full icon name, i.e. logo-javascript instead of javascript (currently).

Additionally it would be great if these icons (i.e. logo-*) are displayed in all columns in the table view, because currently it looks as if they are available only for iOS.

Here is a related forum topic: https://forum.ionicframework.com/t/freebsd-devil-bug/50597

@perrygovier perrygovier added this to the Before "good" milestone May 6, 2016
@mhartington
Copy link
Member

Looks like the actual template for the modal may need to change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants