Skip to content

Commit

Permalink
refactor(vue): only ship es modules (#26054)
Browse files Browse the repository at this point in the history
resolves #25104

BREAKING CHANGE:

`@ionic/vue` and `@ionic/vue-router` no longer ship a CommonJS entry point. Instead, only an ES Module entry point is provided for improved compatibility with Vite.
  • Loading branch information
liamdebeasi committed Sep 30, 2022
1 parent 1f3ddf2 commit 86bbed0
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 16 deletions.
8 changes: 8 additions & 0 deletions BREAKING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ This is a comprehensive list of the breaking changes introduced in the major ver
- [Slides](#version-7x-slides)
- [Textarea](#version-7x-textarea)
- [Virtual Scroll](#version-7x-virtual-scroll)
- [JavaScript Frameworks](#version-7x-javascript-frameworks)
- [Vue](#version-7x-vue)
- [Utilities](#version-7x-utilities)
- [hidden attribute](#version-7x-hidden-attribute)

Expand Down Expand Up @@ -139,6 +141,12 @@ Developers using the component will need to migrate to a virtual scroll solution

Any references to the virtual scroll types from `@ionic/core` have been removed. Please remove or replace these types: `Cell`, `VirtualNode`, `CellType`, `NodeChange`, `HeaderFn`, `ItemHeightFn`, `FooterHeightFn`, `ItemRenderFn` and `DomRenderFn`.

<h2 id="version-7x-javascript-frameworks">JavaScript Frameworks</h2>

<h4 id="version-7x-vue">Vue</h4>

`@ionic/vue` and `@ionic/vue-router` no longer ship a CommonJS entry point. Instead, only an ES Module entry point is provided for improved compatibility with Vite.

<h2 id="version-7x-utilities">Utilities</h2>

<h4 id="version-7x-hidden-attribute">`hidden` attribute</h4>
Expand Down
1 change: 0 additions & 1 deletion packages/vue-router/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"sync": "sh ./scripts/sync.sh"
},
"main": "./dist/index.js",
"module": "./dist/index.esm.js",
"types": "./dist/types/index.d.ts",
"files": [
"dist/"
Expand Down
7 changes: 1 addition & 6 deletions packages/vue-router/rollup.config.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,9 @@
export default {
input: 'dist-transpiled/index.js',
output: [
{
file: 'dist/index.esm.js',
format: 'es',
sourcemap: true,
},
{
file: 'dist/index.js',
format: 'commonjs',
format: 'es',
sourcemap: true,
}
],
Expand Down
1 change: 0 additions & 1 deletion packages/vue/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
"sync": "sh ./scripts/sync.sh"
},
"main": "./dist/index.js",
"module": "./dist/index.esm.js",
"types": "./dist/types/index.d.ts",
"files": [
"dist/",
Expand Down
10 changes: 2 additions & 8 deletions packages/vue/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,11 @@ export default {
output: [
{
dir: 'dist/',
entryFileNames: '[name].esm.js',
chunkFileNames: '[name]-[hash].esm.js',
entryFileNames: '[name].js',
chunkFileNames: '[name]-[hash].js',
format: 'es',
sourcemap: true
},
{
dir: 'dist/',
format: 'commonjs',
preferConst: true,
sourcemap: true
}
],
external: id => external.includes(id) || id.startsWith('@ionic/core') || id.startsWith('ionicons')
};

0 comments on commit 86bbed0

Please sign in to comment.