Skip to content

Commit

Permalink
Revert "bug(breadcrumbs): color attribute shows on DOM for Vue (#27040)…
Browse files Browse the repository at this point in the history
…" (#27069)

This reverts commit dd419c0.

Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
  • Loading branch information
sean-perkins and thetaPC committed Mar 30, 2023
1 parent dd419c0 commit abadeed
Show file tree
Hide file tree
Showing 6 changed files with 2 additions and 71 deletions.
2 changes: 1 addition & 1 deletion core/api.txt
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ ion-breadcrumb,part,native
ion-breadcrumb,part,separator

ion-breadcrumbs,shadow
ion-breadcrumbs,prop,color,"danger" | "dark" | "light" | "medium" | "primary" | "secondary" | "success" | "tertiary" | "warning" | string & Record<never, never> | undefined,undefined,false,true
ion-breadcrumbs,prop,color,"danger" | "dark" | "light" | "medium" | "primary" | "secondary" | "success" | "tertiary" | "warning" | string & Record<never, never> | undefined,undefined,false,false
ion-breadcrumbs,prop,itemsAfterCollapse,number,1,false,false
ion-breadcrumbs,prop,itemsBeforeCollapse,number,1,false,false
ion-breadcrumbs,prop,maxItems,number | undefined,undefined,false,false
Expand Down
2 changes: 1 addition & 1 deletion core/src/components/breadcrumbs/breadcrumbs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class Breadcrumbs implements ComponentInterface {
* Default options are: `"primary"`, `"secondary"`, `"tertiary"`, `"success"`, `"warning"`, `"danger"`, `"light"`, `"medium"`, and `"dark"`.
* For more information on colors, see [theming](/docs/theming/basics).
*/
@Prop({ reflect: true }) color?: Color;
@Prop() color?: Color;

/**
* The maximum number of breadcrumbs to show before collapsing.
Expand Down
4 changes: 0 additions & 4 deletions packages/vue/test/base/src/router/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,6 @@ const routes: Array<RouteRecordRaw> = [
path: '/components',
component: () => import('@/views/Components.vue'),
},
{
path: '/components/breadcrumbs',
component: () => import('@/views/Breadcrumbs.vue')
},
{
path: '/components/select',
component: () => import('@/views/Select.vue')
Expand Down
53 changes: 0 additions & 53 deletions packages/vue/test/base/src/views/Breadcrumbs.vue

This file was deleted.

3 changes: 0 additions & 3 deletions packages/vue/test/base/src/views/Components.vue
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
<ion-page>
<ion-content>
<ion-list>
<ion-item button router-link="/components/breadcrumbs">
<ion-label>Breadcrumbs</ion-label>
</ion-item>
<ion-item button router-link="/components/select">
<ion-label>Select</ion-label>
</ion-item>
Expand Down
9 changes: 0 additions & 9 deletions packages/vue/test/base/tests/e2e/specs/breadcrumbs.cy.js

This file was deleted.

0 comments on commit abadeed

Please sign in to comment.