Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Alert configuration not taking effect on 'disabled' attributes from inputs #13488

Closed
mvsouza opened this issue Nov 22, 2017 · 4 comments · Fixed by #13521
Closed

Bug: Alert configuration not taking effect on 'disabled' attributes from inputs #13488

mvsouza opened this issue Nov 22, 2017 · 4 comments · Fixed by #13521
Assignees

Comments

@mvsouza
Copy link

mvsouza commented Nov 22, 2017

Ionic version: (check one with "x")
[ ] 2.x
[x] 3.x
[ ] 4.x

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request

Current behavior:
When an alert input, that ain't a radio button or a checkbox, have the "disabled" attribute, the input is still editable.

Expected behavior:
The input field shouldn't be editable.

Related code:

https://ionic-ni3hse.stackblitz.io

@kensodemann
Copy link
Member

Hello! Thank you for opening an issue with us!

I couldn't think of a reason not to support disabled on all of the various types of inputs that are allowed. Currently, it is only supported by checkbox and radio buttons. Created pull requests to fix that in v3.x and v4.x

Thank you for using Ionic

@kensodemann
Copy link
Member

PRs are merged. If there is a new release for v3.x it will be in that (there is not currently one planned, but that could change). Otherwise it will be in v4.x

@mvsouza
Copy link
Author

mvsouza commented Nov 29, 2017

Thanks Ken!

ChezRD pushed a commit to ChezRD/ionic that referenced this issue Jan 7, 2018
@ionitron-bot
Copy link

ionitron-bot bot commented Sep 1, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants