Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ionic v4-beta.1] Flexbox properties not working anymore #14985

Closed
marcelgoya opened this issue Aug 2, 2018 · 10 comments
Closed

[Ionic v4-beta.1] Flexbox properties not working anymore #14985

marcelgoya opened this issue Aug 2, 2018 · 10 comments
Labels

Comments

@marcelgoya
Copy link

My dynamic column height flex properties stopped working after upgrading to beta1. They working fine on beta0.

Bug Report

Ionic Info
Run ionic info from a terminal/cmd prompt and paste the output below.


Ionic:

   ionic (Ionic CLI)          : 4.0.2 (/usr/lib/node_modules/ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.1
   @angular-devkit/core       : 0.7.0-rc.3
   @angular-devkit/schematics : 0.7.0-rc.3
   @angular/cli               : 6.0.8
   @ionic/ng-toolkit          : 1.0.0
   @ionic/schematics-angular  : 1.0.1

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : android 7.0.0, ios 4.5.4

System:

   NodeJS : v9.11.2 (/usr/bin/node)
   npm    : 6.2.0
   OS     : Linux 4.4

Environment:

   ANDROID_HOME : not set

Describe the Bug
The height: 100% seems to have stopped working with the latest beta.

Steps to Reproduce

Related Code

<ion-content> 
    <ion-grid> 
      <ion-row style="background-color: #e74c3c;">
        <ion-col>Alizarin!</ion-col>
      </ion-row>
 
      <ion-row style="background-color: #f1c40f;">
        <ion-col>Sunflower!</ion-col>
      </ion-row>
 
      <ion-row style="background-color: #9b59b6;">
        <ion-col>Amethyst!</ion-col>
      </ion-row>
 
    </ion-grid> 
</ion-content>

ion-scroll {
    display: flex;
    flex-direction: column;
}

ion-grid {
    padding: 0;
    height: 100%;
}

ion-row {
    flex: 1;
}

Expected Behavior
The total row height should be 100% and each row should have a dynamic height.

Additional Context

@ionitron-bot ionitron-bot bot added the triage label Aug 2, 2018
@peterpeterparker
Copy link
Contributor

Same here, all the styling I developed for beta.0 regarding flex doesn't work anymore in beta.1

@marcelgoya
Copy link
Author

@peterpeterparker Also, exactly the same styling worked for v3 and below as well ...

@peterpeterparker
Copy link
Contributor

@marcelgoya not 100% the same, I have to custom made a couple of changes for beta.0 but they doesn't work anymore in beta.1

@marcelgoya
Copy link
Author

@peterpeterparker this sucks! To be honest, they've said that v4 is now in beta status but quite frankly they're currently doing exactly the same thing they've done during the migration from v1 to v2, which is publishing half ready software and wasting other peoples time by letting them post issues on their github account. I already had to fix several bugs myself and create patch files. It's all very frustrating and disappointing.

@peterpeterparker
Copy link
Contributor

@marcelgoya I mean per definition a beta software is a beta software

if you wish to have a more stable core you should then maybe had wait for a release candidate or even later stage I guess

P.S.: https://en.wikipedia.org/wiki/Software_release_life_cycle#Beta definition: "Beta phase generally begins when the software is feature complete but likely to contain a number of known or unknown bugs"

@marcelgoya
Copy link
Author

marcelgoya commented Aug 4, 2018

@peterpeterparker Alright, then per definition its still classified as alpha because there is a lot of small stuff still missing like correct platform detection, proper css element styling etc ...

@peterpeterparker
Copy link
Contributor

@marcelgoya as you wish

@peterpeterparker
Copy link
Contributor

As #14996 for me this issue would also be resolve with the PR #15012 I did submit

@peterpeterparker
Copy link
Contributor

All good for me with v4.0.0-beta2, thx a lot 👍

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 9, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants