Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0.0-beta.5] ion-back-button wrong text position in RTL #15357

Closed
berchik opened this issue Aug 28, 2018 · 11 comments
Closed

[4.0.0-beta.5] ion-back-button wrong text position in RTL #15357

berchik opened this issue Aug 28, 2018 · 11 comments
Assignees
Labels
package: core @ionic/core package type: bug a confirmed bug report

Comments

@berchik
Copy link

berchik commented Aug 28, 2018

Bug Report

Ionic Info

Ionic:

   ionic (Ionic CLI)          : 4.1.1 (C:\Users\jo\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.5
   @angular-devkit/core       : 0.7.5
   @angular-devkit/schematics : 0.7.5
   @angular/cli               : 6.1.5
   @ionic/ng-toolkit          : 1.0.7
   @ionic/schematics-angular  : 1.0.5

Cordova:

   cordova (Cordova CLI) : 7.0.1
   Cordova Platforms     : not available
   Cordova Plugins       : not available

System:

   Android SDK Tools : 26.1.1 (A:\Users\Jo\AppData\Local\Android\sdk)
   NodeJS            : v8.9.3 (A:\Program Files\nodejs\node.exe)
   npm               : 6.1.0
   OS                : Windows 10

Describe the Bug

Using dir="rtl", the back button text is located on the wrong side of the icon on IOS,

Top left toolbar showing this Back<
instead of <Back

@ionitron-bot ionitron-bot bot added the triage label Aug 28, 2018
@berchik berchik changed the title [4.0.0-beta.5] ion-back-button wrong position in RTL [4.0.0-beta.5] ion-back-button wrong text position in RTL Aug 28, 2018
@abennouna
Copy link
Contributor

It's the default back icon that is not inverted in RTL mode, in both ios and md modes.
The text is in the correct position relative to the icon.

The correct render should be (back_text) > in ios mode or > in md mode

@AbbasTallaq
Copy link

Same here, even in android the arrow showing in wrong direction

@Guillerbr
Copy link

ok

@AbbasTallaq
Copy link

Am working on ionic 4 dev, if this will be fix soon please update... if going to takes time.. then I will role back to ionic 3...
thanks everybody

@abennouna
Copy link
Contributor

I'm currently using this workaround:

[dir="rtl"] {
  ion-icon {
    &[name="arrow-forward"],
    &[name="arrow-back"] {
      transform: rotateY(180deg);
    }
  }
}

@AbbasTallaq
Copy link

I have tried this workaround, but unfortunately aren't working, I have placed the code in page.scss and even in variable.scss ... still the same the arrows showing the wrong side.

@paulstelzer
Copy link
Contributor

Is this issue still exist in beta.17?

@paulstelzer paulstelzer added needs: reply the issue needs a response from the user and removed triage labels Dec 3, 2018
@abennouna
Copy link
Contributor

Yes: in RTL mode & out of the box, the icons don't rotate by themselves.

You can check the demo here and the demo repository here

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Dec 4, 2018
@paulstelzer paulstelzer added needs: investigation package: core @ionic/core package and removed triage labels Dec 4, 2018
@abennouna
Copy link
Contributor

abennouna commented Dec 4, 2018

Probably the same issue happening in #14958

@paulstelzer
Copy link
Contributor

Yeah, there are a lot of issues related to RTL mode. It would be great if someone can add a PR to resolve this issue

@ionitron-bot
Copy link

ionitron-bot bot commented Feb 13, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

6 participants