Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4.0.0-beta.8] ion-col size not supported #15495

Closed
paulstelzer opened this issue Sep 7, 2018 · 3 comments · Fixed by #15498
Closed

[v4.0.0-beta.8] ion-col size not supported #15495

paulstelzer opened this issue Sep 7, 2018 · 3 comments · Fixed by #15498
Labels

Comments

@paulstelzer
Copy link
Contributor

paulstelzer commented Sep 7, 2018

Bug Report

If you use <ion-col> with the size property (size-md etc), it's not working. I already did some research and found the issue:

In col.tsx (https://github.com/ionic-team/ionic/blob/master/core/src/components/col/col.tsx) the following const columns = this.getColumns('size'); always returns "undefined" (in method calculateSize() ). So it fails and he falls back to auto.

The root cause problem is the matchBreakpoint(); function. That should be:

  if (breakpoint === undefined || breakpoint === '') {
    return true;
  }

I will make a PR, will see if they merge this :D

@ionitron-bot ionitron-bot bot added the triage label Sep 7, 2018
@comino
Copy link

comino commented Sep 7, 2018

I can confirm that and just posted the same issue moments after yours.

#15496

@paulstelzer
Copy link
Contributor Author

@comino I presented the fix above and you could be right: They made changes to that function on 31st August ;)

@ionitron-bot
Copy link

ionitron-bot bot commented Oct 7, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Oct 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants