Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IonConfig swipeBackEnabled not working on 4.0.0-beta17 #16624

Closed
homeportcz opened this issue Dec 7, 2018 · 4 comments · Fixed by #16668
Closed

IonConfig swipeBackEnabled not working on 4.0.0-beta17 #16624

homeportcz opened this issue Dec 7, 2018 · 4 comments · Fixed by #16668
Assignees
Labels
package: angular @ionic/angular package

Comments

@homeportcz
Copy link

homeportcz commented Dec 7, 2018

Bug Report

Ionic Info

Ionic:

   ionic (Ionic CLI)             : 4.4.0
   Ionic Framework               : @ionic/angular 4.0.0-beta.17
   @angular-devkit/build-angular : 0.8.4
   @angular-devkit/schematics    : 0.8.4
   @angular/cli                  : 6.1.5
   @ionic/angular-toolkit        : not installed

Cordova:

   cordova (Cordova CLI) : 7.1.0
   Cordova Platforms     : android 7.1.2, browser 5.0.4, ios 4.5.5
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 2.1.4, (and 15 other plugins)

System:

   Android SDK Tools : 26.0.1 (/Users/jirik/Library/Android/sdk)
   ios-deploy        : 2.0.0
   ios-sim           : 7.0.0
   NodeJS            : v8.12.0 (/usr/local/bin/node)
   npm               : 2.15.12
   OS                : macOS High Sierra
   Xcode             : Xcode 10.0 Build version 10A255

Describe the Bug
IonConfig swipeBackEnabled:false does not work. Still can swipe to go back.
Same behaviour for Android and iOS.

@NgModule({
  declarations: [AppComponent],
  entryComponents: [],
  exports: [],
  imports: [
    BrowserModule,
    BrowserAnimationsModule,
    IonicModule.forRoot({
      mode: 'ios',
      swipeBackEnabled: false,
      backButtonText: ''
    })
]})

Expected Behavior
swipeBackEnabled configuration should be respected

@ionitron-bot ionitron-bot bot added the triage label Dec 7, 2018
@askona
Copy link

askona commented Dec 7, 2018

I'm also having issue after updating to beta.11 ===> beta.16:
When navigating using location.back(); I got empty pages and this warning:
Navigation triggered outside Angular zone, did you forget to call 'ngZone.run()'?

But this appears ONLY on Android devices.

== Actually this issue fixing with updating angular packages from 7.03 to 7.2.1-beta.1 ==

@paulstelzer paulstelzer added needs: investigation package: core @ionic/core package package: angular @ionic/angular package and removed triage package: core @ionic/core package labels Dec 7, 2018
@KevinKelchen
Copy link

I was able to disable swipe-to-go-back by adding [swipeGesture]="false" to ion-router-outlet like so:
<ion-router-outlet main [swipeGesture]="false"></ion-router-outlet>

I have not tried configuring it in IonicConfig like the OP.

@vosecek
Copy link

vosecek commented Dec 11, 2018

I was able to disable swipe-to-go-back by adding [swipeGesture]="false" to ion-router-outlet like so:
<ion-router-outlet main [swipeGesture]="false"></ion-router-outlet>

I have not tried configuring it in IonicConfig like the OP.

Thanks, this works too. Anyway, thanks @manucorporat for fixing it globally.

@ionitron-bot
Copy link

ionitron-bot bot commented Jan 10, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants