fix(datetime): default to local date

[liamdebeasi]

Short description of what this resolves:

This PR fixes an issue where datetimes are not localized to the user's timezone. This PR should fix a number of datetime issues.

Changes proposed in this pull request:

• Create a UTC-like string that has the hours localized to the user's timezone before generating columns in picker
• Set timezone offset before passing to convertDataToISO to ensure that function does not attempt to convert timezones by itself
• Added more tests

Ionic Version:

Fixes: #17587 #16436 #16723

[dominic-ks]

Hi,

Can I just ask, what version have these fixes gone into? I'm still experiencing this and I'm not sure how to check if I have the right version or not.

Thanks,

[liamdebeasi]

This was fixed in Ionic 4.2. There was another bug regarding null values that was fixed in Ionic 4.4. You can view all changes for each Ionic version here: https://ionicframework.com/docs/release-notes

[MKhowaja]

Is there a way to go back to the behavior before this change? Ie ignore the user's device timezone

[MKhowaja]

@liamdebeasi One idea would be to guard the existing behaviour behind a prop that defaults to the new behaviour. This way there would atleast be a possibility of backwards compatibility.