fix(datetime): recalculate day column when month is changed #17815

liamdebeasi · 2019-03-18T19:38:32Z

Short description of what this resolves:

This PR is meant to combine the changes proposed by #17562 and #14434 and to clean up the code a bit. Additionally, this PR also introduces more tests

Changes proposed in this pull request:

Add onIonPickerColChange event to ion-picker-column to allow the datetime component to be aware of the need to recalculate day values
Add tests for ion-picker-column
Add generic test utilities for interaction and listening for evens.

Ionic Version:

Fixes:
#14233
#14732
#15452
#15794
#16733
#17060
#17510
#17521

…onic into datetime-col-change merge

brandyscarney · 2019-03-19T20:04:34Z

When we go to merge this, can we add @KillerCodeMonkey and @olivercodes as co-authors if this is going to close their PRs? https://help.github.com/en/articles/creating-a-commit-with-multiple-authors

core/src/components/datetime/datetime.tsx

core/src/components/picker-column/picker-column.tsx

core/src/components/picker-column/test/standalone/index.html

Co-Authored-By: liamdebeasi <liamdebeasi@users.noreply.github.com>

KillerCodeMonkey · 2019-03-20T16:38:25Z

@liamdebeasi @brandyscarney nice this topic is on its way 🚀

If i can support you here, let me know :)

brandyscarney · 2019-03-20T16:50:13Z

@KillerCodeMonkey Thank you! 🙂 So we found a bug with this PR but we're scheduled to release today so we aren't going to get this in today's release, but we're going to do our normal release and then release a dev build with this PR in it so we can get some community testing. We'll post the dev release here and on some of the datetime issues once it's out.

KillerCodeMonkey · 2019-03-20T16:55:04Z

@brandyscarney

ah okay. so if you need help to solve the bug or need someone to test it 😉 .
I am happy you have this on your agenda, now.

KillerCodeMonkey · 2019-03-20T17:02:17Z

core/src/components/datetime/datetime.tsx

@@ -325,6 +325,7 @@ export class Datetime implements ComponentInterface {
          text: this.cancelText,
          role: 'cancel',
          handler: () => {
+            this.updateDatetimeValue(this.value);


@liamdebeasi thats why i stored the changed value on an internal State in my PR (only as an info) :)

Makes sense! I'd just rather reset it than store two copies of data that could potentially differ

KillerCodeMonkey · 2019-03-20T17:05:48Z

Aye! :) Liam DeBeasi <notifications@github.com> schrieb am Mi., 20. März 2019, 18:04:

…

***@***.**** commented on this pull request. ------------------------------ In core/src/components/datetime/datetime.tsx <#17815 (comment)>: > @@ -325,6 +325,7 @@ export class Datetime implements ComponentInterface { text: this.cancelText, role: 'cancel', handler: () => { + this.updateDatetimeValue(this.value); Makes sense! I'd just rather reset it than store two copies of data that could potentially differ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17815 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACKOYHf32QKTsHGtYDT-ABpbHbPXttJUks5vYmougaJpZM4b6nee> .

KillerCodeMonkey · 2019-03-21T12:53:07Z

Yeeeeeees! Liam DeBeasi <notifications@github.com> schrieb am Do., 21. März 2019, 13:52:

…

Merged #17815 <#17815> into master. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17815 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACKOYMHtTZVKK3do-Zm9UK3uAzXV6t9Nks5vY4CAgaJpZM4b6nee> .

…17815) Co-Authored-By: KillerCodeMonkey <bengtler@gmail.com> Co-Authored-By: olivercodes <boliver@linux.com> Co-Authored-By: liamdebeasi <liamdebeasi@users.noreply.github.com>

…hanged (#17815)" This reverts commit 9273f97.

liamdebeasi · 2019-03-21T12:57:34Z

I was missing a space when adding your name/email for co-authors so I'm going to revert and try it again 🙂

KillerCodeMonkey · 2019-03-21T13:03:48Z

Lols :). AS you wish. But i am not here for the fame *disappears in a magic fog of stardust Liam DeBeasi <notifications@github.com> schrieb am Do., 21. März 2019, 13:58:

…

I was missing a space when adding your name/email for co-authors so I'm going to revert and try it again 🙂 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17815 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACKOYNLLRZXvImdXcGW6t8QruBuCJyF2ks5vY4HrgaJpZM4b6nee> .

…hanged (#17815)" (#17845) This reverts commit 9273f97.

zxdeer · 2019-04-19T02:20:06Z

Short description of what this resolves:

This PR is meant to combine the changes proposed by #17562 and #14434 and to clean up the code a bit. Additionally, this PR also introduces more tests

Changes proposed in this pull request:

Add onIonPickerColChange event to ion-picker-column to allow the datetime component to be aware of the need to recalculate day values

Add tests for ion-picker-column

Add generic test utilities for interaction and listening for evens.

Ionic Version:

Fixes:
#14233
#14732
#15452
#15794
#16733
#17060
#17510
#17521

How use in Ionic?

liamdebeasi · 2019-04-19T02:23:16Z

Hi there,

Please visit the Ionic DateTime Documention for instructions on how to use this component.

Thanks!

olivercodes · 2019-05-14T03:33:47Z

Thank you for the co-author marks @liamdebeasi @brandyscarney, much appreciated

…onic-team#17815) Co-Authored-By: KillerCodeMonkey<bengtler@gmail.com> Co-Authored-By: olivercodes <boliver@linux.com> Co-Authored-By: liamdebeasi <liamdebeasi@users.noreply.github.com>

…hanged (ionic-team#17815)" (ionic-team#17845) This reverts commit 9273f97.

liamdebeasi added 6 commits March 14, 2019 16:40

fix(datetime): update day col on change

8ee763a

clean up

34ddbf9

only allow overriding of velocity check

3f1480c

bug fix

c4c81c6

Merge branch 'datetime-col-change' of https://github.com/ionic-team/i…

4eeec28

…onic into datetime-col-change merge

add picker-col tests

b227856

ionitron-bot bot added the package: core @ionic/core package label Mar 18, 2019

liamdebeasi marked this pull request as ready for review March 18, 2019 19:55

liamdebeasi changed the title ~~Datetime col change~~ fix(datetime): recalculate day column when month is changed Mar 19, 2019

Merge branch 'master' into datetime-col-change

4faa104

liamdebeasi requested a review from brandyscarney March 19, 2019 17:06

liamdebeasi added 2 commits March 20, 2019 11:48

disable change checking for non-dates

7af1c99

cleanup

2a2be15

brandyscarney requested changes Mar 20, 2019

View reviewed changes

liamdebeasi and others added 3 commits March 20, 2019 12:14

make picker col event internal

3960f91

remove console log

76aafe3

Update core/src/components/picker-column/test/standalone/index.html

207841a

Co-Authored-By: liamdebeasi <liamdebeasi@users.noreply.github.com>

reset datevalue object on cancel

80c43c5

KillerCodeMonkey reviewed Mar 20, 2019

View reviewed changes

Merge branch 'master' into datetime-col-change

e0b01dc

liamdebeasi merged commit 9273f97 into master Mar 21, 2019

liamdebeasi added a commit that referenced this pull request Mar 21, 2019

Revert "fix(datetime): recalculate day column when month or year is c…

27b5e19

…hanged (#17815)" This reverts commit 9273f97.

liamdebeasi mentioned this pull request Mar 21, 2019

Revert "fix(datetime): recalculate day column when month is changed" #17845

Merged

liamdebeasi added a commit that referenced this pull request Mar 21, 2019

Revert "fix(datetime): recalculate day column when month or year is c…

e915aed

…hanged (#17815)" (#17845) This reverts commit 9273f97.

liamdebeasi deleted the datetime-col-change branch March 21, 2019 13:08

simonhaenisch mentioned this pull request May 16, 2019

bug: ion-datetime works wrongly with different timezone offsets since 4.2 #18287

Closed

kiku-jw pushed a commit to kiku-jw/ionic that referenced this pull request May 16, 2019

Revert "fix(datetime): recalculate day column when month or year is c…

be17627

…hanged (ionic-team#17815)" (ionic-team#17845) This reverts commit 9273f97.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(datetime): recalculate day column when month is changed #17815

fix(datetime): recalculate day column when month is changed #17815

liamdebeasi commented Mar 18, 2019 •

edited

Loading

brandyscarney commented Mar 19, 2019 •

edited

Loading

KillerCodeMonkey commented Mar 20, 2019

brandyscarney commented Mar 20, 2019

KillerCodeMonkey commented Mar 20, 2019

KillerCodeMonkey Mar 20, 2019

liamdebeasi Mar 20, 2019

KillerCodeMonkey commented Mar 20, 2019 via email

KillerCodeMonkey commented Mar 21, 2019 via email

liamdebeasi commented Mar 21, 2019

KillerCodeMonkey commented Mar 21, 2019 via email

zxdeer commented Apr 19, 2019

Short description of what this resolves:

Changes proposed in this pull request:

liamdebeasi commented Apr 19, 2019

olivercodes commented May 14, 2019

fix(datetime): recalculate day column when month is changed #17815

fix(datetime): recalculate day column when month is changed #17815

Conversation

liamdebeasi commented Mar 18, 2019 • edited Loading

Short description of what this resolves:

Changes proposed in this pull request:

brandyscarney commented Mar 19, 2019 • edited Loading

KillerCodeMonkey commented Mar 20, 2019

brandyscarney commented Mar 20, 2019

KillerCodeMonkey commented Mar 20, 2019

KillerCodeMonkey Mar 20, 2019

Choose a reason for hiding this comment

liamdebeasi Mar 20, 2019

Choose a reason for hiding this comment

KillerCodeMonkey commented Mar 20, 2019 via email

KillerCodeMonkey commented Mar 21, 2019 via email

liamdebeasi commented Mar 21, 2019

KillerCodeMonkey commented Mar 21, 2019 via email

zxdeer commented Apr 19, 2019

Short description of what this resolves:

Changes proposed in this pull request:

liamdebeasi commented Apr 19, 2019

olivercodes commented May 14, 2019

liamdebeasi commented Mar 18, 2019 •

edited

Loading

brandyscarney commented Mar 19, 2019 •

edited

Loading