fix(input): prevent default behaviour on clear text input button #18004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
requested changes
Apr 9, 2019
liamdebeasi
approved these changes
Apr 16, 2019
|
Merged. Thank you! 🎉 |
kiku-jw
pushed a commit
to kiku-jw/ionic
that referenced
this pull request
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When clear-input is used on a input field it loses focus on that field whenever the input is cleared
Issue Number: #18002
What is the new behavior?
A check has been added to prevent default behaviour of the clear-input button, This causes the input field to lose focus. A check is added to only apply this logic whenever the clear-input button is shown since this function is also used for clear-on-edit but would make no sense to apply in that scenario.
Does this introduce a breaking change?