-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: (angular) gesture partial back #18462
Comments
Same issue on "@ionic/angular": "^4.4.2" |
Also experiencing this issue. Page for which |
Same issue - would appreciate a fix |
I can confirm this issue. In my case, I am using the The behaviour is very weird:
We are currently migrating our app to Ionic 4 and this branch is not public yet. But if it would help you in reproducing the error, I can try to make it public. Here is a video: https://streamable.com/tt8p9 EDIT: My temporary solution is to simply disable swipe to go back in the whole application. Ideally I would like to only disable it on some pages, but I couldn't find any docs for it. Is there a way to do that? |
yes sir, I have the same issue, but the problem is now with cordova-plugin-googlemaps, I dont understand, why we need transparent child page? |
|
can we have a hook on while start gesture ??? that can resolve the issue, I can remove the transparent when we while in gesturing and set it back to transparent if you release your finger |
@hiepxanh Yep, I'm in the EXACT same boat as you. Using google maps but the swipe back can cause some odd things to happen. I'm looking into the swipe start gesture stuff as well yeah... I'm stumped. |
@AndreasGassmann I've also considered disabling the swipe back but just for 1 page. In the end I think the UX suffers more from doing that than the chance they do a partial swipe back 😞 . But in the thought experiment I did on HOW to accomplish it:
Really what I want to do is detect if they started a swipe and just force them back if they cancel it. Yes, it will be jarring but better that than to have them see the mess that happens if they cancel the swipe then try to do something more on the page. |
@hiepxanh Ok I've got a REALLY gross work around that involves patching @ionic/angular. It's not pretty but I think it covers all the bases. What I DON'T know is if it breaks anything else. I haven't scripted it yet but it shouldn't be hard to script as a hook. What I'm doing is 2 things.
I do not like or advocate something like this normally, ideally we would at a minimum get the functionality I hacked in as an option like The hackIn
To be fair... It's not really "monkey patching" as I'm pretty sure that is something you do at runtime but I wasn't able to figure out a way to do true "monkey patching" but maybe someone smarter can figure it out so we don't have to edit Like I said this should be easy enough to script into an after_prepare hook or something like that... Edit: Well I feel like a moron, ANOTHER fix that requires NO PATCHING is to just set Obviously the best of all worlds would be to fix the actual issue here so we could drag it and cancel it and not have these problems but.... well someone smarter is going to have to do that, I'm tapped out. Edit 2: Ok here is the file to patch it: https://gist.github.com/joshstrange/23546d07c9294671200d3b5f4c85c934 and you just need to add |
@joshstrange seems overkill...better solution would be to just reapply |
@dansiemens 🤦♂ Yeah it probably would... Ok, well I'm rushing to ship this app in the next 30min but I will play around with a fix that JUST does that later. Thank you, I somehow missed that reading through everything. |
@joshstrange |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Bug Report
Ionic version:
[x] 4.x
Current behavior:
When viewing a Detail view you can swipe back to return to the List view you came from. However if you only drag your finger partially across the screen and return back to the Detail view without removing your finger, the view begins to behave strangely. The List view is now visible.
Expected behavior:
If you start to swipe right to back out of a view and gesture back to pull the page back into view. The previous page should be hidden
Steps to reproduce:
Related code:
https://github.com/Kadinvanvalin/ionic-gesture-back
Other information:
.ion-page-hidden is removed when you start the gesture, but isn't reapplied at the end of the gesture if you end on the "wrong page"
Ionic info:
The text was updated successfully, but these errors were encountered: