fix(virtual-scroll): fix flicker on data change #18851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Currently, if you have an
ion-virtual-scroll
with a list of items and a search bar for filtering them, when you change the list of items, the items disappear until rendered again, causing a flicker. This could be solved for the items using theitemHeight
function to provide the exact height size and bypass some calculations and be more performant etc.However, if you had a header or footer, they would still flicker. This PR adds two more optional functions named
headerHeight
andfooterHeight
that return the exact size of the header and footer respectively and resolve the flicker.Issue Number: #17540
What is the new behavior?
If you provide
headerHeight
and/orfooterHeight
functions asion-virtual-scroll
attributes, with exact height values, the flicker on data change stops.Does this introduce a breaking change?
Other information
This is the current behavior:
This is the new behavior: