-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optionally render ion-icon from asset path if provided #18969
optionally render ion-icon from asset path if provided #18969
Conversation
looks like the CI failure is being caused by a chrome update (to 76) (after fixing up the lint errors)
|
I like the feature, but we probably don't need a new iconSrc API, read my comment ^ |
@manucorporat @brandyscarney thanks, updated the PR accordingly. |
Awesome! this looks great, last two things, |
|
@jfspencer beautiful! |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm run lint
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #18968
What is the new behavior?
supplying
iconSrc
on a ToastButton config object will useDoes this introduce a breaking change?
Other information
npm run build
updated the vue package-lock file. I can remove that from the PR if needed.