Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionally render ion-icon from asset path if provided #18969

Conversation

jfspencer
Copy link
Contributor

@jfspencer jfspencer commented Jul 31, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features) (didn't see a spec file, happy to add tests, just need be pointed in the right direction)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #18968

What is the new behavior?

supplying iconSrc on a ToastButton config object will use

Does this introduce a breaking change?

  • Yes
  • No

Other information

  • Running npm run build updated the vue package-lock file. I can remove that from the PR if needed.

@jfspencer
Copy link
Contributor Author

jfspencer commented Aug 1, 2019

looks like the CI failure is being caused by a chrome update (to 76) (after fixing up the lint errors)

[22:50:06] I/direct - Using ChromeDriver directly...
[22:50:06] E/launcher - session not created: Chrome version must be between 71 and 75

@manucorporat
Copy link
Contributor

I like the feature, but we probably don't need a new iconSrc API, read my comment ^

@jfspencer
Copy link
Contributor Author

@manucorporat @brandyscarney thanks, updated the PR accordingly.

@jfspencer jfspencer changed the title optionally render ion-icon from src path if provided optionally render ion-icon from asset path if provided Aug 1, 2019
@manucorporat
Copy link
Contributor

Awesome! this looks great, last two things,
can you revert the change in vue/package-lock.json ?
also make sure you run npm run build in core and commit the changes!

@jfspencer
Copy link
Contributor Author

@manucorporat

  • remove vue/package-lock
  • commit generated changes after npm run build on core

@manucorporat
Copy link
Contributor

@jfspencer beautiful!
will try to get it merged before the next release!

@adamdbradley adamdbradley merged commit 23f327e into ionic-team:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants