refactor(): remove [main] from split-pane #19511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did we not have deprecation warnings for this? |
brandyscarney
approved these changes
Oct 2, 2019
|
No, I don't think there was ever a deprecation warning for this. |
|
This needs to be updated to include removing the newly added deprecation warning: #19237 |
brandyscarney
pushed a commit
that referenced
this pull request
Oct 7, 2019
brandyscarney
pushed a commit
that referenced
this pull request
Oct 8, 2019
brandyscarney
pushed a commit
that referenced
this pull request
Oct 9, 2019
brandyscarney
pushed a commit
that referenced
this pull request
Oct 10, 2019
elylucas
pushed a commit
that referenced
this pull request
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Split pane allows currently allows users to place the
mainattribute on their content for the split pane to find.What is the new behavior?
Users should use the
contentIdprop to help split pane find its main contentDoes this introduce a breaking change?
Other information