Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Animation] feat: Animation Identifiers #19550

Closed
liamdebeasi opened this issue Oct 4, 2019 · 1 comment
Closed

[Animation] feat: Animation Identifiers #19550

liamdebeasi opened this issue Oct 4, 2019 · 1 comment
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement

Comments

@liamdebeasi
Copy link
Member

Feature Request

Ionic version:

[x] 4.x

Describe the Feature Request

Currently, CSS Animations are given a default/unique ID when created. Web Animations are given no ID. This can cause debugging to be challenging as developers cannot easily identify their animations when using things like the Animation pane in Chrome Dev Tools.

Setting an ID will show up in Chrome dev tools, making animations a bit easier to debug.

Describe Preferred Solution

  1. Expose a way to set an ID on an animation. This ID will be applied to keyframe names/style tags for CSS Animations, and will be set on the id property on an animation object for Web Animations.

  2. Expose a public readonly property called id.

Related Code

createAnimation('my-animation-id')
  .duration(1000)
  .addElement(els)
  .fromTo('opacity', 1, 0);

I don't think we need to expose a new method for this -- just set the ID on animation creation.

@ionitron-bot ionitron-bot bot added the triage label Oct 4, 2019
@liamdebeasi liamdebeasi added package: core @ionic/core package type: feature request a new feature, enhancement, or improvement labels Oct 4, 2019
@ionitron-bot ionitron-bot bot removed triage labels Oct 4, 2019
elylucas pushed a commit that referenced this issue Oct 30, 2019
mhartington pushed a commit that referenced this issue Oct 31, 2019
@ionitron-bot
Copy link

ionitron-bot bot commented Nov 28, 2019

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: core @ionic/core package type: feature request a new feature, enhancement, or improvement
Projects
None yet
Development

No branches or pull requests

1 participant