Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not scrolling with select and data inputs #1985

Closed
mhartington opened this issue Aug 12, 2014 · 5 comments
Closed

Not scrolling with select and data inputs #1985

mhartington opened this issue Aug 12, 2014 · 5 comments
Assignees

Comments

@mhartington
Copy link
Member

Normally if an input is focused, but below the keyboard, the scroll view will scroll to bring the inputs in the middle of the view.

But if you try this with date inputs and selects, no scrolling occurs.

Effect version: beta 11

Relavent code - Past this into a new project and disable scrolling to see the issue.

<ion-content class="has-header">
    <form name="form" novalidate>
        <div class="list list-inset">
            <label class="item item-input item-icon-right item-floating-label">
                <i ng-if="form.email.$valid" class="icon ion-ios7-checkmark-empty valid-check"></i>
                <i ng-if="!form.email.$valid" class="icon ion-ios7-close-empty invalid-check"></i>
                <span class="input-label">E-mail</span>
                <input type="email" name="email" ng-model="user.email" placeholder="E-mail" required>
            </label>
            <label class="item item-input item-icon-right item-floating-label">
                <i ng-if="form.password.$valid" class="icon ion-ios7-checkmark-empty valid-check"></i>
                <i ng-if="!form.password.$valid" class="icon ion-ios7-close-empty invalid-check"></i>
                <span class="input-label">Password</span>
                <input type="password" name="password" ng-model="user.password" placeholder="Password" required>
            </label>
            <label class="item item-input item-icon-right item-floating-label">
                <i ng-if="form.confirm.$valid && user.confirmPass == user.password" class="icon ion-ios7-checkmark-empty valid-check"></i>
                <i ng-if="!form.confirm.$valid || user.confirmPass != user.password" class="icon ion-ios7-close-empty invalid-check"></i>
                <span class="input-label">Confirm</span>
                <input type="password" name="confirm" ng-model="user.confirmPass" placeholder="Confirm Password" required>
            </label>
            <label class="item item-input item-icon-right">
                <i ng-if="form.birthday.$valid && isValidBirthday(user.birthday)" class="icon ion-ios7-checkmark-empty valid-check"></i>
                <i ng-if="!form.birthday.$valid || !isValidBirthday(user.birthday)" class="icon ion-ios7-close-empty invalid-check"></i>
                <span class="input-label large">Birthday</span>
                <input id="date" type="date" name="birthday" ng-model="user.birthday" required>
            </label>
            <label class="gender item item-input item-select">
                <div class="input-label large">
                    Gender
                </div>
                <select ng-model="user.sex">
                    <option value=""></option>
                    <option value="M">Male</option>
                    <option value="F">Female</option>
                </select>
            </label>
        </div>
    </form>
    <div class="padding">
        <button class="button button-block button-positive" ng-disabled="!form.$valid || user.confirmPass != user.password || !isValidBirthday(user.birthday)"
                ng-click="register(user)">
            Register
        </button>
    </div>
</ion-content>
@justinpatten
Copy link

Maybe related to this in keyboard.js?

if( !e.target || !ionic.tap.isTextInput(e.target) || ionic.tap.isDateInput(e.target) || !keyboardIsWithinScroll(e.target)

Looks like it is not scrolling unless it is a text input

@mhartington
Copy link
Member Author

Hm, seems this was to fix another issue, #1638 to be exact. @perrygovier any thoughts?

@Ionitron
Copy link
Collaborator

Greetings!

Due to this issue's age and inactivity, it has been closed.

If you are still experiencing this issue, please feel free to reopen it so we may assist you.
If you wish to get help using the framework itself, the recommended place is the forum.

Thank you for allowing me to assist you.

@tlancina tlancina reopened this Feb 27, 2015
@tlancina tlancina assigned tlancina and unassigned perrygovier Feb 27, 2015
@tlancina
Copy link
Contributor

Should be fixed with 4636cb0.

@rupalpatel0008
Copy link

I am having this same issue on both android and ios.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants