Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action-sheet): action sheet now scrollable and accounts for safe areas on iOS #20145

Merged
merged 1 commit into from Jan 8, 2020

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jan 6, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #17311

What is the new behavior?

  • action sheets intended to be scrollable can now actually be scrolled on iOS
  • account for safe areas when setting max height of action sheet

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Jan 6, 2020
@liamdebeasi liamdebeasi marked this pull request as ready for review January 6, 2020 16:20
@brandyscarney
Copy link
Member

I believe this issue was caused by getting the translucent state working. Can you test this out in Safari too with translucent action sheets? I can if I ever get away from the release stuff. 🙃

@liamdebeasi
Copy link
Contributor Author

It works with translucent action sheets, but the background looks strange since there's no background color. We can add a background color, but that will interfere with the backdrop filter and alter its appearance.

@brandyscarney brandyscarney merged commit 53fad97 into master Jan 8, 2020
@liamdebeasi liamdebeasi deleted the select-scrollable branch January 24, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants