Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: in split-pane, border is invisible in RTL mode #20994

Closed
ataramez opened this issue Apr 8, 2020 · 2 comments
Closed

bug: in split-pane, border is invisible in RTL mode #20994

ataramez opened this issue Apr 8, 2020 · 2 comments
Labels
package: core @ionic/core package type: bug a confirmed bug report
Milestone
5.1.0

Comments

@ataramez
Copy link
Contributor

ataramez commented Apr 8, 2020

Bug Report

Ionic version:
5.x

Current behavior:
in split-pane component, the border between the two panes is invisible if you switched direction from LTR to RTL

Expected behavior:
border should be visible

Steps to reproduce:
create a new app with the sidemenu template. Run the application and make sure that the width is large enough for the menu pane to be visible. Change HTML direction to RTL.

Related code:

Other information:
Simple update to scss files in the component will fix the issue. pull request will be opened shortly

Ionic info:
Ionic:

Ionic CLI : 6.3.0

Utility:

cordova-res : not installed
native-run : not installed

System:

NodeJS : v12.13.0
npm : 6.13.1
OS : Windows 10
@ionitron-bot ionitron-bot bot added the triage label Apr 8, 2020
@liamdebeasi liamdebeasi added package: core @ionic/core package type: bug a confirmed bug report labels Apr 8, 2020
@liamdebeasi liamdebeasi added this to the 5.1.0 milestone Apr 8, 2020
@ionitron-bot ionitron-bot bot removed the triage label Apr 8, 2020
ataramez pushed a commit to ataramez/ionic that referenced this issue Apr 8, 2020
fix(split-pane): show border in RTL mode
7624706 
a new border mixin is added to support borders in both direction modes
(LTR & RTL). This mixin is then used in the split-pane component.

closes ionic-team#20994
ataramez pushed a commit to ataramez/ionic that referenced this issue Apr 8, 2020
fix(split-pane): show border in RTL mode
79d2cf0 
a new border mixin is added to support borders in both direction modes
(LTR & RTL). This mixin is then used in the split-pane component to fix
the bug

closes ionic-team#20994
@liamdebeasi
Copy link
Member

Thanks for the issue. This has been resolved via #20995 and will be available in an upcoming release of Ionic Framework.

@ionitron-bot
Copy link

ionitron-bot bot commented May 8, 2020

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Milestone
5.1.0
Development

No branches or pull requests
2 participants
@liamdebeasi @ataramez