Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add parts support for placeholder, icon, text #21108

Merged
merged 3 commits into from Apr 23, 2020

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Apr 22, 2020

#20916

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Discussed with the team and we decided we did not want to expose this right now.

What is the new behavior?

  • Removed icon-inner part

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Apr 22, 2020
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also use this to uncomment the docs for part?

@liamdebeasi
Copy link
Member Author

@brandyscarney Yeah docs support for it is now in Stencil, so I can remove the "TODO" in all the PRs

Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we merge this let's do it as a feature to add the parts since it's going in the public API

feat(select): add parts support for placeholder, icon, text

@brandyscarney
Copy link
Member

Or break it up into two, whichever you want

@liamdebeasi liamdebeasi changed the title chore(select): remove icon-inner part feat(select): add parts support for placeholder, icon, text Apr 23, 2020
@liamdebeasi liamdebeasi merged commit 30a1c89 into master Apr 23, 2020
@liamdebeasi liamdebeasi deleted the select-part-rm branch April 23, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants