Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-label inside ion-item aligns wrongly or disappers if custom Angular component is used in this ion-item when stacked or floating position is set #22736

Closed
MaximS opened this issue Jan 5, 2021 · 4 comments
Labels
package: angular @ionic/angular package type: bug a confirmed bug report

Comments

@MaximS
Copy link

MaximS commented Jan 5, 2021

ion-label inside ion-item aligns wrongly or disappers if custom Angular component is used in this ion-item when stacked or floating label position is set - because item-label-stacked class is not set on ion-item

Ionic version:

[x] 5.x (Angular project)

Current behavior:
When custom Angular component is used inside ion-item a class item-label-stacked is not set on ion-item if there is a label with position="stacked" inside that ion-item. (When built-in Ionic components like ion-input are used the ion-item gets this class automatically)

Expected behavior:
item-label-stacked class should be set on ion-item regardless of component used after the label

Steps to reproduce:
See Related code

Related code:
See stackblitz link
In a demo item-label-stacked is explicitly added to an ion-item. If it's removed than the label aligns itself to the left like position="fixed" or disappers completely if all the chips are deleted (using red crosses). See comments in tabs/tab1.page.html

@ionitron-bot ionitron-bot bot added the holiday triage issues that were created during holiday period label Jan 5, 2021
@ionitron-bot
Copy link

ionitron-bot bot commented Jan 5, 2021

Thanks for the issue! This issue has been labeled as holiday triage. With the winter holidays quickly approaching, much of the Ionic Team will soon be taking time off. During this time, issue triaging and PR review will be delayed until the team begins to return. After this period, we will work to ensure that all new issues are properly triaged and that new PRs are reviewed.

In the meantime, please read our Winter Holiday Triage Guide for information on how to ensure that your issue is triaged correctly.

Thank you!

@liamdebeasi liamdebeasi added package: angular @ionic/angular package type: bug a confirmed bug report and removed holiday triage issues that were created during holiday period labels Nov 15, 2021
@liamdebeasi
Copy link
Contributor

Hi there,

We are proposing some changes to form components that seek to resolve this issue. We would love your feedback on these proposed changes! You can read more about the changes and leave comments here: #25661

@liamdebeasi liamdebeasi added type: bug a confirmed bug report and removed type: bug a confirmed bug report labels Nov 14, 2022
liamdebeasi added a commit that referenced this issue Nov 15, 2022
@liamdebeasi
Copy link
Contributor

Thanks for the report. In Ionic 7 we will be introducing a new syntax for using form components such as ion-input. You can find a summary of the changes here: #25661

The reported issue is fixed with this new syntax. Work to update ion-input to use this new syntax has been completed, so I am going mark this issue as resolved. We plan to have a public beta period for Ionic 7 in the future. You can visit the Ionic Blog, Ionic Twitter, or our GitHub Releases Page to be notified when the Ionic 7 beta is released. Let me know if you have any questions. Thanks!

@ionitron-bot
Copy link

ionitron-bot bot commented Dec 15, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: angular @ionic/angular package type: bug a confirmed bug report
Projects
None yet
Development

No branches or pull requests

2 participants