Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): add improved method for not unmounting component until overlay is dismissed #22813

Merged
merged 1 commit into from Jan 22, 2021

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: resolves a regression in 14e8441 by adding a better fix for #22761

What is the new behavior?

  • Overlay now only unmounts component if overlay is not open or if overlay is in process of dismissing.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: react @ionic/react package label Jan 22, 2021
@liamdebeasi liamdebeasi merged commit ab1fc8f into master Jan 22, 2021
@liamdebeasi liamdebeasi deleted the react-overlay-dismiss branch January 22, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant