Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion): toggle icon now shows up in vue and react #23426

Merged
merged 1 commit into from Jun 7, 2021

Conversation

liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Vue and React use imports for icons, and since chevronDown was not explicitly imported, the icon never showed up when using accordion in these apps

What is the new behavior?

  • Added explicit import for chevronDown in react and vue

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: react @ionic/react package package: vue @ionic/vue package labels Jun 7, 2021
@liamdebeasi liamdebeasi merged commit c716617 into next Jun 7, 2021
@liamdebeasi liamdebeasi deleted the accordion-icon branch June 7, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant