fix(react): modal now mounts child component independently of other modals #23903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when Ion components such as `IonModal` are created using the `createOverlayComponent` HOC, the isDismissing flag is scoped to the definition of the class. So in this case, when IonModal gets exported, the isDismissing flag is scoped to the IonModal class definition and not an instance of the IonModal. Consider when you have multiple IonModals controlling different dialogs or whatever. So I believe this `isDismissing` flag should be scoped to the instance of the Overlay class, as if I chose to render 10 IonModals, each should be controlled independently.
6 tasks
liamdebeasi
changed the title
liamdebeasi
requested changes
Sep 9, 2021
|
Ready to go! |
|
The code looks good, but do you have a GitHub repo that shows the issue happening? I would like to verify this fix by testing in that app. |
|
@liamdebeasi Yea heres a code sandbox with ionic/react 5.7.0 showcasing the issue. https://codesandbox.io/s/nervous-sky-w954i Repo if you so desire: https://github.com/puopg/ioni-test |
BEFORE:Screen.Recording.2021-09-10.at.10.32.16.AM.movAFTER:Screen.Recording.2021-09-10.at.10.31.55.AM.mov |
|
Merged. Thank you! |
This was referenced Oct 1, 2021
This was referenced Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when Ion components such as
IonModalare created using thecreateOverlayComponentHOC, the isDismissing flag is scoped to the definition of the class. So in this case, when IonModal gets exported, the isDismissing flag is scoped to the IonModal class definition and not an instance of the IonModal.Consider when you have multiple IonModals controlling different dialogs or whatever. So I believe this
isDismissingflag should be scoped to the instance of the Overlay class, as if I chose to render 10 IonModals, each should be controlled independently.Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolves #23904
What is the new behavior?
Does this introduce a breaking change?
Other information