Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(select): add event for when overlay is dismissed #24400

Merged
merged 1 commit into from
Dec 14, 2021
Merged

feat(select): add event for when overlay is dismissed #24400

merged 1 commit into from
Dec 14, 2021

Conversation

amandaejohnston
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #24088

What is the new behavior?

  • New Event ionDismiss is emitted when the created overlay is dismissed

Does this introduce a breaking change?

  • Yes
  • No

Other information

This is identical to #24099, except merged to the new feature branch.

@amandaejohnston amandaejohnston requested a review from a team as a code owner December 14, 2021 15:18
@github-actions github-actions bot added package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package labels Dec 14, 2021
@amandaejohnston amandaejohnston merged commit c40b8c4 into feature-6.1 Dec 14, 2021
@amandaejohnston amandaejohnston deleted the select-dismiss-event branch December 14, 2021 15:34
@amandaejohnston amandaejohnston mentioned this pull request Feb 8, 2022
Closed
sean-perkins pushed a commit that referenced this pull request Mar 2, 2022
@amandaejohnston @sean-perkins
feat(select): add event for when overlay is dismissed (#24400)
d507400
sean-perkins pushed a commit that referenced this pull request Mar 9, 2022
@amandaejohnston @sean-perkins
feat(select): add event for when overlay is dismissed (#24400)
5059f65
sean-perkins pushed a commit that referenced this pull request Mar 10, 2022
@amandaejohnston @sean-perkins
feat(select): add event for when overlay is dismissed (#24400)
b835b7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@amandaejohnston