Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ion-popover is missing side input for Angular bindings #24466

Closed
4 of 6 tasks
guillaume-petit opened this issue Dec 22, 2021 · 3 comments · Fixed by #24470
Closed
4 of 6 tasks

bug: ion-popover is missing side input for Angular bindings #24466

guillaume-petit opened this issue Dec 22, 2021 · 3 comments · Fixed by #24470
Labels
package: angular @ionic/angular package type: bug a confirmed bug report

Comments

@guillaume-petit
Copy link

guillaume-petit commented Dec 22, 2021

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

According to v6 popover documentation, there should be a "side" attribute available for choosing which side to display the popover.

But I can't see this attribute available in the current implementation of the popover angular directive.

Am I completely missing the point or is something missing?

Expected Behavior

The "side" attribute on the ion-popover element should allow me to choose on which side of the reference point the popover displays.

Steps to Reproduce

<ion-popover trigger="add-item-button" dismiss-on-select side="top">    <= Adding "side" attribute has no effect
  <ng-template>
    <ion-content>
Some code
    </ion-content>
  </ng-template>
</ion-popover>

Code Reproduction URL

No response

Ionic Info

[ERROR] Error loading @angular-devkit/schematics package.json: Error: Cannot find module      
        '@angular-devkit/schematics/package'
        
        Require stack:
        - C:\Users\Guillaume Petit\AppData\Roaming\npm\node_modules\ionic\lib\project\index.js
        - C:\Users\Guillaume Petit\AppData\Roaming\npm\node_modules\ionic\lib\index.js        
        - C:\Users\Guillaume Petit\AppData\Roaming\npm\node_modules\ionic\index.js
        - C:\Users\Guillaume Petit\AppData\Roaming\npm\node_modules\ionic\bin\ionic

Ionic:

   Ionic CLI                     : 5.4.16 (C:\Users\Guillaume Petit\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework               : @ionic/angular 6.0.0
   @angular-devkit/build-angular : 13.1.2
   @angular-devkit/schematics    : not installed
   @angular/cli                  : 13.1.2
   @ionic/angular-toolkit        : 4.0.0

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   NodeJS : v14.17.0 (D:\Development\Tools\nodejs\node.exe)
   npm    : 7.10.0
   OS     : Windows 10

Additional Information

No response

@ionitron-bot ionitron-bot bot added the holiday triage issues that were created during holiday period label Dec 22, 2021
@ionitron-bot
Copy link

ionitron-bot bot commented Dec 22, 2021

Thanks for the issue! This issue has been labeled as holiday triage. With the winter holidays quickly approaching, much of the Ionic Team will soon be taking time off. During this time, issue triaging and PR review will be delayed until the team begins to return. After this period, we will work to ensure that all new issues are properly triaged and that new PRs are reviewed.

In the meantime, please read our Winter Holiday Triage Guide for information on how to ensure that your issue is triaged correctly.

Thank you!

@sean-perkins
Copy link
Contributor

@guillaume-petit thanks for reporting this issue! On a quick review, it appears the directive is missing the side prop for both the ProxyCmp and Component inputs.

This means that the value supplied to the directive is not being forwarded to the HTML element.

@sean-perkins sean-perkins added package: angular @ionic/angular package type: bug a confirmed bug report labels Dec 22, 2021
@ionitron-bot ionitron-bot bot removed the holiday triage issues that were created during holiday period label Dec 22, 2021
@sean-perkins sean-perkins changed the title bug: bug: ion-popover is missing side input for Angular bindings Dec 22, 2021
@ionitron-bot
Copy link

ionitron-bot bot commented Feb 3, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: angular @ionic/angular package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants