Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): popover will respect side attribute value #24470

Merged
merged 1 commit into from
Jan 4, 2022
Merged

Conversation

sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The side property for ion-popover is not being passed to the HTML element with the Angular proxies.

Issue Number: Resolves #24466

What is the new behavior?

Adds missing side input binding for the ion-popover Angular proxies.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@sean-perkins sean-perkins requested a review from a team as a code owner December 22, 2021 16:34
@github-actions github-actions bot added the package: angular @ionic/angular package label Dec 22, 2021
@Saqib92
Copy link

Saqib92 commented Feb 14, 2022

still not working. Side attribute not working.

@amandaejohnston
Copy link
Contributor

@Saqib92 Could you open a separate issue and include a repo we can use to reproduce the problem?

@Saqib92
Copy link

Saqib92 commented Feb 14, 2022

@Saqib92 Could you open a separate issue and include a repo we can use to reproduce the problem?

Please check this issue:

#24780 (comment)

this is happening if my ion datetime is at bottom of my page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: ion-popover is missing side input for Angular bindings
4 participants