Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Angular Inline Sheet Modal are not updated #24502

Closed
4 of 6 tasks
Marius-Romanus opened this issue Jan 2, 2022 · 3 comments · Fixed by #24521
Closed
4 of 6 tasks

bug: Angular Inline Sheet Modal are not updated #24502

Marius-Romanus opened this issue Jan 2, 2022 · 3 comments · Fixed by #24521
Labels
package: angular @ionic/angular package type: bug a confirmed bug report

Comments

@Marius-Romanus
Copy link

Marius-Romanus commented Jan 2, 2022

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

CommonModule Angular directives for example ngFor or ngIf inside Inline Sheet Modal are not updated. I think because of ng-template. For example, you can't do a search and update the list.

Expected Behavior

Items should be updated.

Steps to Reproduce

Create an Inline Sheet Modal with a list with items and a ngFor, update the array.

Code Reproduction URL

https://github.com/Marius-Romanus/ionic-bug-modals-24502
https://stackblitz.com/edit/ionic-angular-v5-g9hhgc?file=src%2Fapp%2Fapp.component.ts

Ionic Info

Ionic:

Ionic CLI : 6.18.1

Utility:

cordova-res : not installed globally
native-run : 1.5.0

System:

NodeJS : v17.3.0
npm : 8.3.0
OS : Windows 10

Additional Information

No response

@ionitron-bot ionitron-bot bot added the holiday triage issues that were created during holiday period label Jan 2, 2022
@ionitron-bot
Copy link

ionitron-bot bot commented Jan 2, 2022

Thanks for the issue! This issue has been labeled as holiday triage. With the winter holidays quickly approaching, much of the Ionic Team will soon be taking time off. During this time, issue triaging and PR review will be delayed until the team begins to return. After this period, we will work to ensure that all new issues are properly triaged and that new PRs are reviewed.

In the meantime, please read our Winter Holiday Triage Guide for information on how to ensure that your issue is triaged correctly.

Thank you!

@Marius-Romanus Marius-Romanus changed the title bug: bug: Inline Sheet Modal are not updated Jan 2, 2022
@Marius-Romanus Marius-Romanus changed the title bug: Inline Sheet Modal are not updated bug: Angular Inline Sheet Modal are not updated Jan 2, 2022
@sean-perkins sean-perkins self-assigned this Jan 5, 2022
@sean-perkins sean-perkins added the package: angular @ionic/angular package label Jan 5, 2022
@ionitron-bot ionitron-bot bot removed the holiday triage issues that were created during holiday period label Jan 5, 2022
@sean-perkins
Copy link
Contributor

Thanks @Marius-Romanus for reporting this issue.

There does appear to be an issue with dynamically changing the values bound within the ng-template for inline modal usage. This applies to pipes, structural directives, etc.

I'll need to dig a little deeper into our inline usage to see if there's anywhere we are caching the template reference that is conflicting with how Angular triggers change detection on those projected templates.

@sean-perkins sean-perkins added the type: bug a confirmed bug report label Jan 5, 2022
sean-perkins added a commit that referenced this issue Jan 6, 2022
sean-perkins added a commit that referenced this issue Jan 6, 2022
@sean-perkins sean-perkins removed their assignment Jan 6, 2022
sean-perkins added a commit that referenced this issue Jan 6, 2022
Allow template bindings to update with inline overlays.

Resolves #24502
sean-perkins added a commit that referenced this issue Jan 6, 2022
Allow template bindings to update with inline overlays.

Resolves #24502
@ionitron-bot
Copy link

ionitron-bot bot commented Feb 5, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Feb 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: angular @ionic/angular package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants