Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): apply touch, dirty and pristine form control classes #24558

Merged
merged 3 commits into from
Jan 12, 2022

Conversation

sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Jan 12, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Monkey patched methods for form controls are not applied, resulting in Ionic classes not being applied when the methods are programmatically called.

Issue Number: #24483

What is the new behavior?

Removes the invalid check used for accessing form controls, not public API methods. This will apply the monkey patch for the individual dirty, pristine and touch methods to sync related Ionic classes.

Does this introduce a breaking change?

  • Yes
  • No

Other information

I believe unintentionally in #23970 the incorrect check was introduced.

@sean-perkins sean-perkins requested a review from a team as a code owner January 12, 2022 04:09
@github-actions github-actions bot added the package: angular @ionic/angular package label Jan 12, 2022
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants