fix(angular): routerLink with null value works with Angular 13 #24622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
reviewed
Jan 21, 2022
liamdebeasi
approved these changes
Jan 21, 2022
amandaejohnston
approved these changes
Jan 21, 2022
This was referenced Feb 1, 2022
jongbonga
pushed a commit
to ntls-io/nautilus-wallet
that referenced
this pull request
Mar 10, 2022
longtomjr
pushed a commit
to ntls-io/nautilus-wallet
that referenced
this pull request
Mar 11, 2022
* build(web-client): upgrade to angular 13 * build(web-client): upgrade ngneat plugins * build(web-client): upgrade eslint plugins * build(web-client): upgrade rxjs * build(web-client): update ts-node & @types/node * build(web-client): upgrade chromatic * fix(web-client): replace toPromise where needed * build(web-client): update to angular 13.1 * build(web-client): update qrcode plugin to latest * chore(web-client): update storybook to 6.4.14 * build(web-client): update to latest ng * build(web-client): update storybook latest patch * fix(web-client): resolve eslint/member-ordering * refactor(web-client): remove nullish coalescing from action-item issue was fixed in ionic-team/ionic-framework#24622 * build(web-client): update ionic to fix null routerlink * build(web-client): update zxing, rxjs & zone * build(web-client): run audit fix * fix(web-client): update Sentry integration * refactor(web-client): set tailwind darkMode to media * build(web-client): update ng to latest patch * fix(web-client): revert darkMode value in tailwind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Ionic Angular apps on Angular 13 will throw an exception when using
[routerLink]="null"(new feature with Angular 13 to disable the router link).Issue Number: #24586
What is the new behavior?
[routerLink]="null"now works with Ionic apps with Angular 13Does this introduce a breaking change?
Other information
Branched as a dependent of #24621, as we should upgrade the test app before patching fixes specific to Angular 13 without a reproduction app. Will update the base branch once that PR is reviewed, approved and merged.