Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: release 6.0.6 breaks my ion-datetime modal - should this method still work? #24750

Closed
4 of 6 tasks
richardkshergold opened this issue Feb 9, 2022 · 6 comments · Fixed by #24751
Closed
4 of 6 tasks
Labels
package: angular @ionic/angular package type: bug a confirmed bug report

Comments

@richardkshergold
Copy link

richardkshergold commented Feb 9, 2022

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

In 6.0.5 my date picker appeared and worked.

In 6.0.6 but none of the buttons work and the app is unresponsive.

The date item uses a modal for display and is part of a form layout and this is my current code which is broken in 6.0.6 but worked in 6.0.5

<div *ngFor="let option of widget['options']">
      <ion-grid>
        <ion-row>
          <ion-col size="8">
            <ion-item detail = "false">
              <ion-label>{{formatDate(form.controls[option._id].value)}}</ion-label>
            </ion-item>
          </ion-col>
          <ion-col size="2">
            <ion-icon
              name="calendar-outline"
              size="large"
              [id]="option._id">
            </ion-icon>
          </ion-col>
          <ion-col size="2">
            <ion-button
              size="small"
              (click)="clearSelection(option._id)"
              fill="outline">
              Clear
            </ion-button>
          </ion-col>
        </ion-row>
      </ion-grid>
      <ion-modal mode="md" [trigger]="option._id">
        <ng-template mode="md">
          <ion-content mode="md" force-overscroll="false">
            <ion-datetime
              showDefaultButtons="true"
              presentation="date"
              [formControlName]="option._id">
            </ion-datetime>
          </ion-content>
        </ng-template>
      </ion-modal>
    </div>

Expected Behavior

The date-time modal should display.

Steps to Reproduce

Try something similar to the code above.

Should this method (opening with a modal) still work in 6.0.6 ?

Code Reproduction URL

No response

Ionic Info

Ionic:

Ionic CLI : 6.18.1 (/Users/xxx/.nvm/versions/node/v16.13.0/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 6.0.6
@angular-devkit/build-angular : 13.2.2
@angular-devkit/schematics : 13.2.2
@angular/cli : 13.2.2
@ionic/angular-toolkit : 5.0.3

Capacitor:

Capacitor CLI : 3.4.0
@capacitor/android : 3.4.0
@capacitor/core : 3.4.0
@capacitor/ios : 3.4.0

Utility:

cordova-res : not installed globally
native-run : 1.5.0

System:

NodeJS : v16.13.0 (/Users/xxx/.nvm/versions/node/v16.13.0/bin/node)
npm : 8.1.0
OS : macOS Monterey

Additional Information

I have switched back to 6.0.5 and my ion-datetime modal is working fine

@ionitron-bot ionitron-bot bot added the triage label Feb 9, 2022
@liamdebeasi
Copy link
Contributor

Can you attach the reproduction as a GitHub repo we can clone?

@liamdebeasi liamdebeasi added the needs: reply the issue needs a response from the user label Feb 9, 2022
@ionitron-bot ionitron-bot bot removed the triage label Feb 9, 2022
@richardkshergold
Copy link
Author

I'm not able to do that unfortunately - I would imagine just copying the icon and modal stuff from the code above should re-produce it though (and hardcoding the model rather than using my IDs). I'm done for the day today but will try and investigate tomorrow if I have time. Thanks

@ionitron-bot ionitron-bot bot added triage and removed needs: reply the issue needs a response from the user labels Feb 9, 2022
@richardkshergold
Copy link
Author

Testing on an iPhone SE by the way (iOS 15.2)

@liamdebeasi
Copy link
Contributor

Thanks! I was able to reproduce the issue. I will work on a fix and get an update shipped out. Thanks for the report.

@liamdebeasi
Copy link
Contributor

This will be fixed in Ionic 6.0.7 (should be released in about 10 minutes). Thanks for the report!

@ionitron-bot
Copy link

ionitron-bot bot commented Mar 11, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: angular @ionic/angular package type: bug a confirmed bug report
Projects
None yet
2 participants