fix(tabs): angular, fire willChange event before selected tab changes #24910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
requested changes
Mar 9, 2022
There was a problem hiding this comment.
Here's a branch that demonstrates how to add an E2E test over this behavior.
https://github.com/ionic-team/ionic-framework/tree/test/FW-17
Verified it will fail against main vs. pass on your branch.
|
@sean-perkins Oh, sweet! Would you mind slapping that onto this branch? I didn't even think about using a separate counter like that, haha. |
|
Done 👍 feel free to tweak anything. I'll wait for CI before re-reviewing. |
liamdebeasi
approved these changes
Mar 9, 2022
sean-perkins
approved these changes
Mar 9, 2022
This was referenced Mar 30, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
In Angular, the
ionTabsWillChangeevent fires after the active tab has already changed.Issue URL: Resolves #18900
What is the new behavior?
The event now fires before the active tab changes.
Does this introduce a breaking change?
Other information