Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): tapping the active tab button now correctly resets the tab stack #24935

Merged
merged 5 commits into from
Mar 14, 2022

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Mar 14, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #24934

What is the new behavior?

  • Tapping the active tab button now goes back to the initial tabs entry instead of pushing a new entry.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Note: This issue has always been present in Ionic Vue, but users always ran into #23873 first so this issue never appeared.

@liamdebeasi liamdebeasi requested a review from a team as a code owner March 14, 2022 16:36
@github-actions github-actions bot added the package: vue @ionic/vue package label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: vue, tapping tab to go to root no longer works as expected
3 participants