Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): canDismiss definition is now exposed #25195

Merged
merged 7 commits into from
Apr 26, 2022
Merged

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Apr 26, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • The canDismiss property was not auto generated on the ion-modal instance.
  • This PR also updated the GitHub Actions workflows to ensure that all framework integration build results have been committed to the repo (to avoid this issue in the future).
    Note: I bumped the Node version on CI from 15.x to 16.x. There were some fixes in node 16 that caused package-lock files to be generated differently.

What is the new behavior?

  • Added the canDismiss property to the modal vue wrapper

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from a team as a code owner April 26, 2022 16:37
@github-actions github-actions bot added the package: vue @ionic/vue package label Apr 26, 2022
@github-actions github-actions bot removed the package: vue @ionic/vue package label Apr 26, 2022
@github-actions github-actions bot added the package: vue @ionic/vue package label Apr 26, 2022
@github-actions github-actions bot added package: angular @ionic/angular package package: react @ionic/react package labels Apr 26, 2022
@liamdebeasi liamdebeasi removed the request for review from a team April 26, 2022 17:07
@liamdebeasi liamdebeasi requested a review from a team April 26, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants