fix(angular): add support for Angular 14 #25403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
reviewed
Jun 6, 2022
amandaejohnston
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Applications that are upgrading from Angular 13 to Angular 14 will receive an exception that breaks the entire app experience.
This is due to the deprecation and removal of
ComponentFactoryResolverin Angular 14.Issue URL: #25353
What is the new behavior?
Does this introduce a breaking change?
Other information
Dev-build:
6.1.9-dev.11654275237.1b595be3Angular 14 demo: https://github.com/sean-perkins/angular-14-demo
For Angular 13, you can use the starters and install the dev-build.
Note: Standalone components are not supported in this phase of development. As far as I can tell, they require
EnvironmentInjectorand other essential infrastructure only available in the Angular 14 bundle. More exploration is required to pass the application's injector through to Ionic's module.